Commit cf07da65 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

cpus-common: remove redundant call to exclusive_idle() 



No need to call exclusive_idle() from cpu_exec_end since it is done
immediately afterwards in cpu_exec_start.  Any exclusive section could
run as soon as cpu_exec_end leaves, because cpu->running is false and the
mutex is not taken, so the call does not add any protection either.

Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent c978b316

cpus-common.c

+0 −1
Original line number Diff line number Diff line
@@ -221,7 +221,6 @@ void cpu_exec_end(CPUState *cpu) 
            qemu_cond_signal(&exclusive_cond);

        }

    }

    exclusive_idle();

    qemu_mutex_unlock(&qemu_cpu_list_lock);

}

docs/tcg-exclusive.promela

+0 −1
Original line number Diff line number Diff line
@@ -124,7 +124,6 @@ byte has_waiter[N_CPUS]; 
        }                                                                    \

        :: else -> skip;                                                     \

    fi;                                                                      \

    exclusive_idle();                                                        \

    MUTEX_UNLOCK(mutex);



// Promela processes