Commit ceff5bd7 authored by Max Reitz's avatar Max Reitz
Browse files

block: Fix bdrv_iterate_format() sorting 



bdrv_iterate_format() did not actually sort the formats by name but by
"pointer interpreted as string". That is probably not what we intended
to do, so fix it (by changing qsort_strcmp() so it matches the example
from qsort()'s manual page).

Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20161012204907.25941-2-mreitz@redhat.com
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 07555ba6

block.c

+1 −1
Original line number Diff line number Diff line
@@ -2796,7 +2796,7 @@ const char *bdrv_get_format_name(BlockDriverState *bs) 


static int qsort_strcmp(const void *a, const void *b)

{

    return strcmp(a, b);

    return strcmp(*(char *const *)a, *(char *const *)b);

}



void bdrv_iterate_format(void (*it)(void *opaque, const char *name),