Commit ce9f5e27 authored by Richard Henderson's avatar Richard Henderson
Browse files

cputlb: Remove tb_invalidate_phys_page_range is_cpu_write_access 



All callers pass false to this argument.  Remove it and pass the
constant on to tb_invalidate_phys_page_range__locked.

Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent b56668bb

accel/tcg/translate-all.c

+2 −4
Original line number Diff line number Diff line
@@ -1983,8 +1983,7 @@ tb_invalidate_phys_page_range__locked(struct page_collection *pages, 
 *

 * Called with mmap_lock held for user-mode emulation

 */

void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,

                                   int is_cpu_write_access)

void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end)

{

    struct page_collection *pages;

    PageDesc *p;
@@ -1996,8 +1995,7 @@ void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end, 
        return;

    }

    pages = page_collection_lock(start, end);

    tb_invalidate_phys_page_range__locked(pages, p, start, end,

                                          is_cpu_write_access);

    tb_invalidate_phys_page_range__locked(pages, p, start, end, 0);

    page_collection_unlock(pages);

}

accel/tcg/translate-all.h

+1 −2
Original line number Diff line number Diff line
@@ -28,8 +28,7 @@ struct page_collection *page_collection_lock(tb_page_addr_t start, 
void page_collection_unlock(struct page_collection *set);

void tb_invalidate_phys_page_fast(struct page_collection *pages,

                                  tb_page_addr_t start, int len);

void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,

                                   int is_cpu_write_access);

void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end);

void tb_check_watchpoint(CPUState *cpu);



#ifdef CONFIG_USER_ONLY

exec.c

+2 −2
Original line number Diff line number Diff line
@@ -1012,7 +1012,7 @@ const char *parse_cpu_option(const char *cpu_option) 
void tb_invalidate_phys_addr(target_ulong addr)

{

    mmap_lock();

    tb_invalidate_phys_page_range(addr, addr + 1, 0);

    tb_invalidate_phys_page_range(addr, addr + 1);

    mmap_unlock();

}
@@ -1039,7 +1039,7 @@ void tb_invalidate_phys_addr(AddressSpace *as, hwaddr addr, MemTxAttrs attrs) 
        return;

    }

    ram_addr = memory_region_get_ram_addr(mr) + addr;

    tb_invalidate_phys_page_range(ram_addr, ram_addr + 1, 0);

    tb_invalidate_phys_page_range(ram_addr, ram_addr + 1);

    rcu_read_unlock();

}