Commit cd5a5271 authored by Samuel Ortiz's avatar Samuel Ortiz Committed by Michael S. Tsirkin
Browse files

hw: acpi: The RSDP build API can return void 



For both x86 and ARM architectures, the internal RSDP build API can
return void as the current return value is unused.

Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarAndrew Jones <drjones@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 4b49b586

hw/arm/virt-acpi-build.c

+1 −3
Original line number Diff line number Diff line
@@ -367,7 +367,7 @@ static void acpi_dsdt_add_power_button(Aml *scope) 
}



/* RSDP */

static GArray *

static void

build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned xsdt_tbl_offset)

{

    AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
@@ -392,8 +392,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned xsdt_tbl_offset) 
    bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,

        (char *)rsdp - rsdp_table->data, sizeof *rsdp,

        (char *)&rsdp->checksum - rsdp_table->data);



    return rsdp_table;

}



static void

hw/i386/acpi-build.c

+1 −3
Original line number Diff line number Diff line
@@ -2547,7 +2547,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) 
                 "IVRS", table_data->len - iommu_start, 1, NULL, NULL);

}



static GArray *

static void

build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned rsdt_tbl_offset)

{

    AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
@@ -2569,8 +2569,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned rsdt_tbl_offset) 
    bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,

        (char *)rsdp - rsdp_table->data, sizeof *rsdp,

        (char *)&rsdp->checksum - rsdp_table->data);



    return rsdp_table;

}



typedef