Commit cc871b1c authored by David Hildenbrand's avatar David Hildenbrand Committed by Markus Armbruster
Browse files

test-string-input-visitor: Split off uint64 list tests 



Basically copy all int64 list tests but adapt them to work on uint64
instead. The values for very big/very small values have to be adapted.

Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20181121164421.20780-9-david@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 13088593

tests/test-string-input-visitor.c

+109 −4
Original line number Diff line number Diff line
@@ -112,7 +112,6 @@ static void test_visitor_in_intList(TestInputVisitorData *data, 
    int64_t expect2[] = { 32767, -32768, -32767 };

    int64_t expect3[] = { INT64_MIN, INT64_MAX };

    int64_t expect4[] = { 1 };

    uint64_t expect5[] = { UINT64_MAX };

    Error *err = NULL;

    int64List *res = NULL;

    Visitor *v;
@@ -133,9 +132,6 @@ static void test_visitor_in_intList(TestInputVisitorData *data, 
    v = visitor_input_test_init(data, "1-1");

    check_ilist(v, expect4, ARRAY_SIZE(expect4));



    v = visitor_input_test_init(data, "18446744073709551615");

    check_ulist(v, expect5, ARRAY_SIZE(expect5));



    /* Value too large */



    v = visitor_input_test_init(data, "9223372036854775808");
@@ -211,6 +207,113 @@ static void test_visitor_in_intList(TestInputVisitorData *data, 
    visit_end_list(v, NULL);

}



static void test_visitor_in_uintList(TestInputVisitorData *data,

                                     const void *unused)

{

    uint64_t expect1[] = { 1, 2, 0, 2, 3, 4, 20, 5, 6, 7,

                           8, 9, 1, 2, 3, 4, 5, 6, 7, 8 };

    uint64_t expect2[] = { 32767, -32768, -32767 };

    uint64_t expect3[] = { INT64_MIN, INT64_MAX };

    uint64_t expect4[] = { 1 };

    uint64_t expect5[] = { UINT64_MAX };

    Error *err = NULL;

    uint64List *res = NULL;

    Visitor *v;

    uint64_t val;



    /* Valid lists */



    v = visitor_input_test_init(data, "1,2,0,2-4,20,5-9,1-8");

    check_ulist(v, expect1, ARRAY_SIZE(expect1));



    v = visitor_input_test_init(data, "32767,-32768--32767");

    check_ulist(v, expect2, ARRAY_SIZE(expect2));



    v = visitor_input_test_init(data,

                                "-9223372036854775808,9223372036854775807");

    check_ulist(v, expect3, ARRAY_SIZE(expect3));



    v = visitor_input_test_init(data, "1-1");

    check_ulist(v, expect4, ARRAY_SIZE(expect4));



    v = visitor_input_test_init(data, "18446744073709551615");

    check_ulist(v, expect5, ARRAY_SIZE(expect5));



    /* Value too large */



    v = visitor_input_test_init(data, "18446744073709551616");

    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    /* Value too small */



    v = visitor_input_test_init(data, "-18446744073709551616");

    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    /* Range not ascending */



    v = visitor_input_test_init(data, "3-1");

    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    v = visitor_input_test_init(data, "18446744073709551615-0");

    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    /* Range too big (65536 is the limit against DOS attacks) */



    v = visitor_input_test_init(data, "0-65536");

    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    /* Empty list */



    v = visitor_input_test_init(data, "");

    visit_type_uint64List(v, NULL, &res, &error_abort);

    g_assert(!res);



    /* Not a list */



    v = visitor_input_test_init(data, "not an uint list");



    visit_type_uint64List(v, NULL, &res, &err);

    error_free_or_abort(&err);

    g_assert(!res);



    /* Unvisited list tail */



    v = visitor_input_test_init(data, "0,2-3");



    visit_start_list(v, NULL, NULL, 0, &error_abort);

    visit_type_uint64(v, NULL, &val, &error_abort);

    g_assert_cmpuint(val, ==, 0);

    visit_type_uint64(v, NULL, &val, &error_abort);

    g_assert_cmpuint(val, ==, 2);



    visit_check_list(v, &err);

    error_free_or_abort(&err);

    visit_end_list(v, NULL);



    /* Visit beyond end of list */



    v = visitor_input_test_init(data, "0");



    visit_start_list(v, NULL, NULL, 0, &error_abort);

    visit_type_uint64(v, NULL, &val, &err);

    g_assert_cmpuint(val, ==, 0);

    visit_type_uint64(v, NULL, &val, &err);

    error_free_or_abort(&err);



    visit_check_list(v, &error_abort);

    visit_end_list(v, NULL);

}



static void test_visitor_in_bool(TestInputVisitorData *data,

                                 const void *unused)

{
@@ -384,6 +487,8 @@ int main(int argc, char **argv) 
                           &in_visitor_data, test_visitor_in_int);

    input_visitor_test_add("/string-visitor/input/intList",

                           &in_visitor_data, test_visitor_in_intList);

    input_visitor_test_add("/string-visitor/input/uintList",

                           &in_visitor_data, test_visitor_in_uintList);

    input_visitor_test_add("/string-visitor/input/bool",

                           &in_visitor_data, test_visitor_in_bool);

    input_visitor_test_add("/string-visitor/input/number",