Commit cc386e96 authored by Dmitry Fleytman's avatar Dmitry Fleytman Committed by Stefan Hajnoczi
Browse files

virtio-net: broken RX filtering logic fixed 



Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command
multicast list overwrites unicast list in mac_table.
This leads to broken logic for both unicast and multicast RX filtering.

Signed-off-by: default avatarDmitry Fleytman <dfleytma@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 1597591c

hw/net/virtio-net.c

+2 −1
Original line number Diff line number Diff line
@@ -657,7 +657,8 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd, 
    }



    if (n->mac_table.in_use + mac_data.entries <= MAC_TABLE_ENTRIES) {

        s = iov_to_buf(iov, iov_cnt, 0, n->mac_table.macs,

        s = iov_to_buf(iov, iov_cnt, 0,

                       &n->mac_table.macs[n->mac_table.in_use * ETH_ALEN],

                       mac_data.entries * ETH_ALEN);

        if (s != mac_data.entries * ETH_ALEN) {

            goto error;