Commit cc28c6aa authored by Max Reitz's avatar Max Reitz Committed by Stefan Hajnoczi
Browse files

block/raw-posix: Strip protocol prefix on creation 



The hdev_create() implementation in block/raw-posix.c is used by the
"host_device", "host_cdrom" and "host_floppy" protocol block drivers
together. Thus, any of the associated prefixes may occur and exactly one
should should be stripped, if it does (thus,
"host_device:host_cdrom:/dev/cdrom" is not shortened to "/dev/cdrom").

Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Reviewed-by: default avatarBenoit Canet <benoit@irqsave.net>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 18fa1c42

block/raw-posix.c

+12 −0
Original line number Diff line number Diff line
@@ -1776,6 +1776,18 @@ static int hdev_create(const char *filename, QEMUOptionParameter *options, 
    int ret = 0;

    struct stat stat_buf;

    int64_t total_size = 0;

    bool has_prefix;



    /* This function is used by all three protocol block drivers and therefore

     * any of these three prefixes may be given.

     * The return value has to be stored somewhere, otherwise this is an error

     * due to -Werror=unused-value. */

    has_prefix =

        strstart(filename, "host_device:", &filename) ||

        strstart(filename, "host_cdrom:" , &filename) ||

        strstart(filename, "host_floppy:", &filename);



    (void)has_prefix;



    /* Read out options */

    while (options && options->name) {