Commit cbf82fa0 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

ehci: clear suspend bit on detach 

When a device is detached, clear the suspend bit (PORTSC_SUSPEND)
in the port status register.

The specs are not *that* clear what is supposed to happen in case
a suspended device is unplugged.  But the enable bit (PORTSC_PED)
is cleared, and the specs mention setting suspend with enable being
unset is undefined behavior.  So clearing them both looks reasonable,
and it actually fixes the reported bug.

https://bugzilla.redhat.com/show_bug.cgi?id=1268879



Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Message-id: 1445413462-18004-1-git-send-email-kraxel@redhat.com
parent 3d861a01

hw/usb/hcd-ehci.c

+1 −1
Original line number Diff line number Diff line
@@ -726,7 +726,7 @@ static void ehci_detach(USBPort *port) 
    ehci_queues_rip_device(s, port->dev, 0);

    ehci_queues_rip_device(s, port->dev, 1);



    *portsc &= ~(PORTSC_CONNECT|PORTSC_PED);

    *portsc &= ~(PORTSC_CONNECT|PORTSC_PED|PORTSC_SUSPEND);

    *portsc |= PORTSC_CSC;



    ehci_raise_irq(s, USBSTS_PCD);