Commit cb4e5f8e authored by Naphtali Sprei's avatar Naphtali Sprei Committed by Anthony Liguori
Browse files

block: read-only: open cdrom as read-only when using monitor's change command 



Current code of monitor command: 'change', used to open file for read-write
uncoditionally. Change to open it as read-only for CDROM, and read-write for all others.

Signed-off-by: default avatarNaphtali Sprei <nsprei@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 288e7bcc

monitor.c

+3 −1
Original line number Diff line number Diff line
@@ -1087,6 +1087,7 @@ static int do_change_block(Monitor *mon, const char *device, 
{

    BlockDriverState *bs;

    BlockDriver *drv = NULL;

    int bdrv_flags;



    bs = bdrv_find(device);

    if (!bs) {
@@ -1103,7 +1104,8 @@ static int do_change_block(Monitor *mon, const char *device, 
    if (eject_device(mon, bs, 0) < 0) {

        return -1;

    }

    if (bdrv_open(bs, filename, BDRV_O_RDWR, drv) < 0) {

    bdrv_flags = bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM ? 0 : BDRV_O_RDWR;

    if (bdrv_open(bs, filename, bdrv_flags, drv) < 0) {

        qerror_report(QERR_OPEN_FILE_FAILED, filename);

        return -1;

    }