Commit ca89f720 authored by Eduardo Habkost's avatar Eduardo Habkost Committed by Gerd Hoffmann
Browse files

audio: Move arch_init audio code to hw/audio/soundhw.c 



There's no reason to keep the soundhw table in arch_init.c. Move
that code to a new hw/audio/soundhw.c file.

While moving the code, trivial coding style issues were fixed.

Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20170508205735.23444-2-ehabkost@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 56821559

arch_init.c

+0 −124
Original line number Diff line number Diff line
@@ -85,130 +85,6 @@ int graphic_depth = 32; 


const uint32_t arch_type = QEMU_ARCH;



struct soundhw {

    const char *name;

    const char *descr;

    int enabled;

    int isa;

    union {

        int (*init_isa) (ISABus *bus);

        int (*init_pci) (PCIBus *bus);

    } init;

};



static struct soundhw soundhw[9];

static int soundhw_count;



void isa_register_soundhw(const char *name, const char *descr,

                          int (*init_isa)(ISABus *bus))

{

    assert(soundhw_count < ARRAY_SIZE(soundhw) - 1);

    soundhw[soundhw_count].name = name;

    soundhw[soundhw_count].descr = descr;

    soundhw[soundhw_count].isa = 1;

    soundhw[soundhw_count].init.init_isa = init_isa;

    soundhw_count++;

}



void pci_register_soundhw(const char *name, const char *descr,

                          int (*init_pci)(PCIBus *bus))

{

    assert(soundhw_count < ARRAY_SIZE(soundhw) - 1);

    soundhw[soundhw_count].name = name;

    soundhw[soundhw_count].descr = descr;

    soundhw[soundhw_count].isa = 0;

    soundhw[soundhw_count].init.init_pci = init_pci;

    soundhw_count++;

}



void select_soundhw(const char *optarg)

{

    struct soundhw *c;



    if (is_help_option(optarg)) {

    show_valid_cards:



        if (soundhw_count) {

             printf("Valid sound card names (comma separated):\n");

             for (c = soundhw; c->name; ++c) {

                 printf ("%-11s %s\n", c->name, c->descr);

             }

             printf("\n-soundhw all will enable all of the above\n");

        } else {

             printf("Machine has no user-selectable audio hardware "

                    "(it may or may not have always-present audio hardware).\n");

        }

        exit(!is_help_option(optarg));

    }

    else {

        size_t l;

        const char *p;

        char *e;

        int bad_card = 0;



        if (!strcmp(optarg, "all")) {

            for (c = soundhw; c->name; ++c) {

                c->enabled = 1;

            }

            return;

        }



        p = optarg;

        while (*p) {

            e = strchr(p, ',');

            l = !e ? strlen(p) : (size_t) (e - p);



            for (c = soundhw; c->name; ++c) {

                if (!strncmp(c->name, p, l) && !c->name[l]) {

                    c->enabled = 1;

                    break;

                }

            }



            if (!c->name) {

                if (l > 80) {

                    error_report("Unknown sound card name (too big to show)");

                }

                else {

                    error_report("Unknown sound card name `%.*s'",

                                 (int) l, p);

                }

                bad_card = 1;

            }

            p += l + (e != NULL);

        }



        if (bad_card) {

            goto show_valid_cards;

        }

    }

}



void audio_init(void)

{

    struct soundhw *c;

    ISABus *isa_bus = (ISABus *) object_resolve_path_type("", TYPE_ISA_BUS, NULL);

    PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);



    for (c = soundhw; c->name; ++c) {

        if (c->enabled) {

            if (c->isa) {

                if (!isa_bus) {

                    error_report("ISA bus not available for %s", c->name);

                    exit(1);

                }

                c->init.init_isa(isa_bus);

            } else {

                if (!pci_bus) {

                    error_report("PCI bus not available for %s", c->name);

                    exit(1);

                }

                c->init.init_pci(pci_bus);

            }

        }

    }

}



int kvm_available(void)

{

#ifdef CONFIG_KVM

hw/audio/Makefile.objs

+2 −0
Original line number Diff line number Diff line
@@ -14,3 +14,5 @@ common-obj-$(CONFIG_PL041) += pl041.o lm4549.o 
common-obj-$(CONFIG_CS4231) += cs4231.o

common-obj-$(CONFIG_MARVELL_88W8618) += marvell_88w8618.o

common-obj-$(CONFIG_MILKYMIST) += milkymist-ac97.o



common-obj-y += soundhw.o

hw/audio/soundhw.c

0 → 100644
+156 −0
Original line number Diff line number Diff line 
/*

 * QEMU System Emulator

 *

 * Copyright (c) 2003-2008 Fabrice Bellard

 *

 * Permission is hereby granted, free of charge, to any person obtaining a copy

 * of this software and associated documentation files (the "Software"), to deal

 * in the Software without restriction, including without limitation the rights

 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

 * copies of the Software, and to permit persons to whom the Software is

 * furnished to do so, subject to the following conditions:

 *

 * The above copyright notice and this permission notice shall be included in

 * all copies or substantial portions of the Software.

 *

 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL

 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,

 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN

 * THE SOFTWARE.

 */

#include "qemu/osdep.h"

#include "qemu-common.h"

#include "qemu/help_option.h"

#include "qemu/error-report.h"

#include "qom/object.h"

#include "hw/isa/isa.h"

#include "hw/pci/pci.h"

#include "hw/audio/audio.h"



struct soundhw {

    const char *name;

    const char *descr;

    int enabled;

    int isa;

    union {

        int (*init_isa) (ISABus *bus);

        int (*init_pci) (PCIBus *bus);

    } init;

};



static struct soundhw soundhw[9];

static int soundhw_count;



void isa_register_soundhw(const char *name, const char *descr,

                          int (*init_isa)(ISABus *bus))

{

    assert(soundhw_count < ARRAY_SIZE(soundhw) - 1);

    soundhw[soundhw_count].name = name;

    soundhw[soundhw_count].descr = descr;

    soundhw[soundhw_count].isa = 1;

    soundhw[soundhw_count].init.init_isa = init_isa;

    soundhw_count++;

}



void pci_register_soundhw(const char *name, const char *descr,

                          int (*init_pci)(PCIBus *bus))

{

    assert(soundhw_count < ARRAY_SIZE(soundhw) - 1);

    soundhw[soundhw_count].name = name;

    soundhw[soundhw_count].descr = descr;

    soundhw[soundhw_count].isa = 0;

    soundhw[soundhw_count].init.init_pci = init_pci;

    soundhw_count++;

}



void select_soundhw(const char *optarg)

{

    struct soundhw *c;



    if (is_help_option(optarg)) {

    show_valid_cards:



        if (soundhw_count) {

             printf("Valid sound card names (comma separated):\n");

             for (c = soundhw; c->name; ++c) {

                 printf ("%-11s %s\n", c->name, c->descr);

             }

             printf("\n-soundhw all will enable all of the above\n");

        } else {

             printf("Machine has no user-selectable audio hardware "

                    "(it may or may not have always-present audio hardware).\n");

        }

        exit(!is_help_option(optarg));

    }

    else {

        size_t l;

        const char *p;

        char *e;

        int bad_card = 0;



        if (!strcmp(optarg, "all")) {

            for (c = soundhw; c->name; ++c) {

                c->enabled = 1;

            }

            return;

        }



        p = optarg;

        while (*p) {

            e = strchr(p, ',');

            l = !e ? strlen(p) : (size_t) (e - p);



            for (c = soundhw; c->name; ++c) {

                if (!strncmp(c->name, p, l) && !c->name[l]) {

                    c->enabled = 1;

                    break;

                }

            }



            if (!c->name) {

                if (l > 80) {

                    error_report("Unknown sound card name (too big to show)");

                }

                else {

                    error_report("Unknown sound card name `%.*s'",

                                 (int) l, p);

                }

                bad_card = 1;

            }

            p += l + (e != NULL);

        }



        if (bad_card) {

            goto show_valid_cards;

        }

    }

}



void audio_init(void)

{

    struct soundhw *c;

    ISABus *isa_bus = (ISABus *) object_resolve_path_type("", TYPE_ISA_BUS, NULL);

    PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);



    for (c = soundhw; c->name; ++c) {

        if (c->enabled) {

            if (c->isa) {

                if (!isa_bus) {

                    error_report("ISA bus not available for %s", c->name);

                    exit(1);

                }

                c->init.init_isa(isa_bus);

            } else {

                if (!pci_bus) {

                    error_report("PCI bus not available for %s", c->name);

                    exit(1);

                }

                c->init.init_pci(pci_bus);

            }

        }

    }

}

hw/ppc/prep.c

+1 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ 
#include "hw/pci/pci_host.h"

#include "hw/ppc/ppc.h"

#include "hw/boards.h"

#include "hw/audio/audio.h"

#include "qemu/error-report.h"

#include "qemu/log.h"

#include "hw/ide.h"

include/hw/audio/audio.h

+3 −0
Original line number Diff line number Diff line
@@ -7,4 +7,7 @@ void isa_register_soundhw(const char *name, const char *descr, 
void pci_register_soundhw(const char *name, const char *descr,

                          int (*init_pci)(PCIBus *bus));



void audio_init(void);

void select_soundhw(const char *optarg);



#endif