Commit c9d40709 authored by Kevin Wolf's avatar Kevin Wolf Committed by Markus Armbruster
Browse files

file-posix: Add dynamic-auto-read-only QAPI feature 



In commit 23dece19 ('file-posix: Make auto-read-only dynamic') ,
auto-read-only=on changed its behaviour in file-posix for the 4.0
release. This change cannot be detected through the usual mechanisms
like schema introspection. Add a new feature flag to the schema to
allow libvirt to detect the presence of the new behaviour.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Message-Id: <20190606153803.5278-7-armbru@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
[Comment tweaked on Eric Blake's advice]
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent f3ed93d5

qapi/block-core.json

+12 −1
Original line number Diff line number Diff line
@@ -2859,6 +2859,15 @@ 
#                         file is large, do not use in production.

#                         (default: off) (since: 3.0)

#

# Features:

# @dynamic-auto-read-only: If present, enabled auto-read-only means that the

#                          driver will open the image read-only at first,

#                          dynamically reopen the image file read-write when

#                          the first writer is attached to the node and reopen

#                          read-only when the last writer is detached. This

#                          allows giving QEMU write permissions only on demand

#                          when an operation actually needs write access.

#

# Since: 2.9

##

{ 'struct': 'BlockdevOptionsFile',
@@ -2868,7 +2877,9 @@ 
            '*aio': 'BlockdevAioOptions',

	    '*drop-cache': {'type': 'bool',

	                    'if': 'defined(CONFIG_LINUX)'},

            '*x-check-cache-dropped': 'bool' } }

            '*x-check-cache-dropped': 'bool' },

  'features': [ { 'name': 'dynamic-auto-read-only',

                  'if': 'defined(CONFIG_POSIX)' } ] }



##

# @BlockdevOptionsNull: