Commit c98c6c10 authored May 19, 2016 by Prasad J Pandit Committed by Paolo Bonzini May 23, 2016

esp: check command buffer length before write(CVE-2016-4439)



The 53C9X Fast SCSI Controller(FSC) comes with an internal 16-byte
FIFO buffer. It is used to handle command and data transfer. While
writing to this command buffer 's->cmdbuf[TI_BUFSZ=16]', a check
was missing to validate input length. Add check to avoid OOB write
access.

Fixes CVE-2016-4439.

Reported-by: Li Qiang <liqiang6-s@360.cn>
Cc: qemu-stable@nongnu.org
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <1463654371-11169-2-git-send-email-ppandit@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent fd28938b

hw/scsi/esp.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -448,7 +448,11 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
		break;
		case ESP_FIFO:
		if (s->do_cmd) {
		if (s->cmdlen < TI_BUFSZ) {
		s->cmdbuf[s->cmdlen++] = val & 0xff;
		} else {
		trace_esp_error_fifo_overrun();
		}
		} else if (s->ti_size == TI_BUFSZ - 1) {
		trace_esp_error_fifo_overrun();
		} else {