Commit c95ac103 authored by Thomas Huth's avatar Thomas Huth
Browse files

cpu: Provide a proper prototype for target_words_bigendian() in a header 



We've got three places already that provide a prototype for this
function in a .c file - that's ugly. Let's provide a proper prototype
in a header instead, with a proper description why this function should
not be used in most cases.

Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
parent 8c827c53

exec.c

+0 −5
Original line number Diff line number Diff line
@@ -3906,11 +3906,6 @@ int qemu_target_page_bits_min(void) 
}

#endif



/*

 * A helper function for the _utterly broken_ virtio device model to find out if

 * it's running on a big endian machine. Don't do this at home kids!

 */

bool target_words_bigendian(void);

bool target_words_bigendian(void)

{

#if defined(TARGET_WORDS_BIGENDIAN)

hw/virtio/virtio.c

+0 −1
Original line number Diff line number Diff line
@@ -1169,7 +1169,6 @@ int virtio_set_status(VirtIODevice *vdev, uint8_t val) 
    return 0;

}



bool target_words_bigendian(void);

static enum virtio_device_endian virtio_default_endian(void)

{

    if (target_words_bigendian()) {

include/qom/cpu.h

+11 −0
Original line number Diff line number Diff line
@@ -1085,6 +1085,17 @@ void cpu_exec_initfn(CPUState *cpu); 
void cpu_exec_realizefn(CPUState *cpu, Error **errp);

void cpu_exec_unrealizefn(CPUState *cpu);



/**

 * target_words_bigendian:

 * Returns true if the (default) endianness of the target is big endian,

 * false otherwise. Note that in target-specific code, you can use

 * TARGET_WORDS_BIGENDIAN directly instead. On the other hand, common

 * code should normally never need to know about the endianness of the

 * target, so please do *not* use this function unless you know very well

 * what you are doing!

 */

bool target_words_bigendian(void);



#ifdef NEED_CPU_H



#ifdef CONFIG_SOFTMMU

qom/cpu.c

+0 −1
Original line number Diff line number Diff line
@@ -194,7 +194,6 @@ static bool cpu_common_debug_check_watchpoint(CPUState *cpu, CPUWatchpoint *wp) 
    return true;

}



bool target_words_bigendian(void);

static bool cpu_common_virtio_is_big_endian(CPUState *cpu)

{

    return target_words_bigendian();