Commit c8a7cafa authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/zpci: drop msix.available 



I fail to see why this is useful as we require MSIX always and
completely fail adding a device.

Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20181105110313.29312-2-david@redhat.com>
Fixes: 4f6482bf
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarCollin Walling <walling@linux.ibm.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent bb9bf94b

hw/s390x/s390-pci-bus.c

+0 −2
Original line number Diff line number Diff line
@@ -745,7 +745,6 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev) 


    pos = pci_find_capability(pbdev->pdev, PCI_CAP_ID_MSIX);

    if (!pos) {

        pbdev->msix.available = false;

        return -1;

    }
@@ -761,7 +760,6 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev) 
    pbdev->msix.pba_bar = pba & PCI_MSIX_FLAGS_BIRMASK;

    pbdev->msix.pba_offset = pba & ~PCI_MSIX_FLAGS_BIRMASK;

    pbdev->msix.entries = (ctrl & PCI_MSIX_FLAGS_QSIZE) + 1;

    pbdev->msix.available = true;



    name = g_strdup_printf("msix-s390-%04x", pbdev->uid);

    memory_region_init_io(&pbdev->msix_notify_mr, OBJECT(pbdev),

hw/s390x/s390-pci-bus.h

+0 −1
Original line number Diff line number Diff line
@@ -252,7 +252,6 @@ typedef struct ChscSeiNt2Res { 
} QEMU_PACKED ChscSeiNt2Res;



typedef struct S390MsixInfo {

    bool available;

    uint8_t table_bar;

    uint8_t pba_bar;

    uint16_t entries;