Commit c87621ea authored by John Snow's avatar John Snow Committed by Jeff Cody
Browse files

blockjobs: split interface into public/private, Part 1 



To make it a little more obvious which functions are intended to be
public interface and which are intended to be for use only by jobs
themselves, split the interface into "public" and "private" files.

Convert blockjobs (e.g. block/backup) to using the private interface.
Leave blockdev and others on the public interface.

There are remaining uses of private state by qemu-img, and several
cases in blockdev.c and block/io.c where we grab job->blk for the
purposes of acquiring an AIOContext.

These will be corrected in future patches.

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Message-id: 1477584421-1399-7-git-send-email-jsnow@redhat.com
Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
parent 0df4ba58

block/backup.c

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ 
#include "trace.h"

#include "block/block.h"

#include "block/block_int.h"

#include "block/blockjob.h"

#include "block/blockjob_int.h"

#include "block/block_backup.h"

#include "qapi/error.h"

#include "qapi/qmp/qerror.h"

block/commit.c

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
#include "qemu/osdep.h"

#include "trace.h"

#include "block/block_int.h"

#include "block/blockjob.h"

#include "block/blockjob_int.h"

#include "qapi/error.h"

#include "qapi/qmp/qerror.h"

#include "qemu/ratelimit.h"

block/mirror.c

+1 −1
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ 


#include "qemu/osdep.h"

#include "trace.h"

#include "block/blockjob.h"

#include "block/blockjob_int.h"

#include "block/block_int.h"

#include "sysemu/block-backend.h"

#include "qapi/error.h"

block/stream.c

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ 
#include "qemu/osdep.h"

#include "trace.h"

#include "block/block_int.h"

#include "block/blockjob.h"

#include "block/blockjob_int.h"

#include "qapi/error.h"

#include "qapi/qmp/qerror.h"

#include "qemu/ratelimit.h"

blockjob.c

+1 −1
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@ 
#include "qemu-common.h"

#include "trace.h"

#include "block/block.h"

#include "block/blockjob.h"

#include "block/blockjob_int.h"

#include "block/block_int.h"

#include "sysemu/block-backend.h"

#include "qapi/qmp/qerror.h"