Commit c80276b4 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

input: add trace events for full queues 



It isn't unusual to happen, for example during reboot when the guest
doesn't reveice events for a while.  So better don't flood stderr
with alarming messages.  Turn them into tracepoints instead so they
can be enabled in case they are needed for trouble-shooting.

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Message-id: 1466675495-28797-1-git-send-email-kraxel@redhat.com
parent d7b7f526

hw/input/hid.c

+2 −1
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include "ui/console.h"

#include "qemu/timer.h"

#include "hw/input/hid.h"

#include "trace.h"



#define HID_USAGE_ERROR_ROLLOVER        0x01

#define HID_USAGE_POSTFAIL              0x02
@@ -234,7 +235,7 @@ static void hid_keyboard_event(DeviceState *dev, QemuConsole *src, 
                                             key->down,

                                             scancodes);

    if (hs->n + count > QUEUE_LENGTH) {

        fprintf(stderr, "usb-kbd: warning: key event queue full\n");

        trace_hid_kbd_queue_full();

        return;

    }

    for (i = 0; i < count; i++) {

hw/input/trace-events

+6 −0
Original line number Diff line number Diff line
@@ -23,3 +23,9 @@ milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %08x value % 
milkymist_softusb_mevt(uint8_t m) "m %d"

milkymist_softusb_kevt(uint8_t m) "m %d"

milkymist_softusb_pulse_irq(void) "Pulse IRQ"



# hw/input/hid.c

hid_kbd_queue_full(void) "queue full"



# hw/input/virtio

virtio_input_queue_full(void) "queue full"

hw/input/virtio-input.c

+2 −1
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
#include "qemu/osdep.h"

#include "qapi/error.h"

#include "qemu/iov.h"

#include "trace.h"



#include "hw/qdev.h"

#include "hw/virtio/virtio.h"
@@ -47,7 +48,7 @@ void virtio_input_send(VirtIOInput *vinput, virtio_input_event *event) 
    virtqueue_get_avail_bytes(vinput->evt, &have, NULL, need, 0);

    if (have < need) {

        vinput->qindex = 0;

        fprintf(stderr, "%s: ENOSPC in vq, dropping events\n", __func__);

        trace_virtio_input_queue_full();

        return;

    }