Commit c7dbff4b authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Eduardo Habkost
Browse files

i386: improve sorting of CPU model names 



The current list of CPU model names output by "-cpu help" is sorted
alphabetically based on the internal QOM class name. The text that is
displayed, however, uses the CPU model name, which is equivalent to the
QOM class name, minus a suffix. Unfortunately that suffix has an effect
on the sort ordering, for example, causing the various Broadwell
variants to appear reversed:

  x86 486
  x86 Broadwell-IBRS        Intel Core Processor (Broadwell, IBRS)
  x86 Broadwell-noTSX-IBRS  Intel Core Processor (Broadwell, no TSX, IBRS
  x86 Broadwell-noTSX       Intel Core Processor (Broadwell, no TSX)
  x86 Broadwell             Intel Core Processor (Broadwell)
  x86 Conroe                Intel Celeron_4x0 (Conroe/Merom Class Core 2)

By sorting on the actual CPU model name text that is displayed, the
result is

  x86 486
  x86 Broadwell             Intel Core Processor (Broadwell)
  x86 Broadwell-IBRS        Intel Core Processor (Broadwell, IBRS)
  x86 Broadwell-noTSX       Intel Core Processor (Broadwell, no TSX)
  x86 Broadwell-noTSX-IBRS  Intel Core Processor (Broadwell, no TSX, IBRS)
  x86 Conroe                Intel Celeron_4x0 (Conroe/Merom Class Core 2)

This requires extra string allocations during sorting, but this is not a
concern given the usage scenario and the number of CPU models that exist.

Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180606165527.17365-3-berrange@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 081492ca

target/i386/cpu.c

+9 −5
Original line number Diff line number Diff line
@@ -3351,15 +3351,19 @@ static gint x86_cpu_list_compare(gconstpointer a, gconstpointer b) 
    ObjectClass *class_b = (ObjectClass *)b;

    X86CPUClass *cc_a = X86_CPU_CLASS(class_a);

    X86CPUClass *cc_b = X86_CPU_CLASS(class_b);

    const char *name_a, *name_b;

    char *name_a, *name_b;

    int ret;



    if (cc_a->ordering != cc_b->ordering) {

        return cc_a->ordering - cc_b->ordering;

        ret = cc_a->ordering - cc_b->ordering;

    } else {

        name_a = object_class_get_name(class_a);

        name_b = object_class_get_name(class_b);

        return strcmp(name_a, name_b);

        name_a = x86_cpu_class_get_model_name(cc_a);

        name_b = x86_cpu_class_get_model_name(cc_b);

        ret = strcmp(name_a, name_b);

        g_free(name_a);

        g_free(name_b);

    }

    return ret;

}



static GSList *get_sorted_cpu_model_list(void)