Commit c76efd72 authored by David Gibson's avatar David Gibson Committed by Michael S. Tsirkin
Browse files

pcie: Remove redundant test in pcie_mmcfg_data_{read,write}() 



These functions have an explicit test for accesses above the device's
config size.  But pci_host_config_{read,write}_common() which they're
about to call already have checks against the config space limit and
do the right thing.  So, remove the redundant tests.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Message-Id: <20190424041959.4087-2-david@gibson.dropbear.id.au>
parent acbd487d

hw/pci/pcie_host.c

+0 −10
Original line number Diff line number Diff line
@@ -47,11 +47,6 @@ static void pcie_mmcfg_data_write(void *opaque, hwaddr mmcfg_addr, 
    }

    addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr);

    limit = pci_config_size(pci_dev);

    if (limit <= addr) {

        /* conventional pci device can be behind pcie-to-pci bridge.

           256 <= addr < 4K has no effects. */

        return;

    }

    pci_host_config_write_common(pci_dev, addr, limit, val, len);

}
@@ -70,11 +65,6 @@ static uint64_t pcie_mmcfg_data_read(void *opaque, 
    }

    addr = PCIE_MMCFG_CONFOFFSET(mmcfg_addr);

    limit = pci_config_size(pci_dev);

    if (limit <= addr) {

        /* conventional pci device can be behind pcie-to-pci bridge.

           256 <= addr < 4K has no effects. */

        return ~0x0;

    }

    return pci_host_config_read_common(pci_dev, addr, limit, len);

}