Commit c618e300 authored Aug 30, 2017 by Daniel Henrique Barboza Committed by David Gibson Sep 08, 2017

hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev

This patch makes a small fix in 'spapr_drc_needed' to change how we detect
if a DRC has a device attached. Previously it used dr_entity_sense for this,
which works for physical DRCs.

However, for logical DRCs, it didn't cover the case where a logical DRC has
a drc->dev but the state is LOGICAL_UNUSABLE (e.g. a hotplugged CPU before
CAS). In this case, the dr_entity_sense of this DRC returns UNUSABLE and the
code was considering that there were no dev attached, making spapr_drc_needed
return 'false' when in fact we would like to migrate the DRC.

Changing it to check for drc->dev instead works for all DRC types.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

parent cda4a338

hw/ppc/spapr_drc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -464,10 +464,9 @@ static bool spapr_drc_needed(void *opaque)
		{
		sPAPRDRConnector drc = (sPAPRDRConnector )opaque;
		sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
		sPAPRDREntitySense value = drck->dr_entity_sense(drc);

		/* If no dev is plugged in there is no need to migrate the DRC state */
		if (value != SPAPR_DR_ENTITY_SENSE_PRESENT) {
		if (!drc->dev) {
		return false;
		}