Commit c5bd6d02 authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Michael S. Tsirkin
Browse files

libqos: add missing virtio-9p feature negotiation 



VIRTIO Device Initialization requires feature negotiation.  The libqos
virtio-9p driver lacks feature negotiation and is therefore
non-compliant.

libqos tests acknowledge all feature bits advertised by the device,
except VIRTIO_F_BAD_FEATURE (which devices use to detect broken
drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not implemented in
libqos and accepting it would break notifications).

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191023100425.12168-7-stefanha@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarThomas Huth" <thuth@redhat.com>
parent 36d27d21

tests/libqos/virtio-9p.c

+6 −0
Original line number Diff line number Diff line
@@ -32,6 +32,12 @@ static void virtio_9p_cleanup(QVirtio9P *interface) 


static void virtio_9p_setup(QVirtio9P *interface)

{

    uint64_t features;



    features = qvirtio_get_features(interface->vdev);

    features &= ~(QVIRTIO_F_BAD_FEATURE | (1ull << VIRTIO_RING_F_EVENT_IDX));

    qvirtio_set_features(interface->vdev, features);



    interface->vq = qvirtqueue_setup(interface->vdev, alloc, 0);

    qvirtio_set_driver_ok(interface->vdev);

}