Commit c575fa67 authored by Thomas Huth's avatar Thomas Huth Committed by Cornelia Huck
Browse files

hw/s390x/ipl: Bail out if the network bootloader can not be found 



If QEMU fails to load 's390-netboot.img', the guest firmware currently
loops forever and just floods the console with "Network boot device
detected" messages. The code in ipl.c apparently already tried to stop
the VM with vm_stop() in this case, but this is in vain since the run
state is later reset due to a call to vm_start() from vl.c again.
To avoid the ugly firmware loop, let's simply exit QEMU directly instead
since it just does not make sense to continue if the required firmware
image can not be loaded. While we're at it, also add the file name of
the netboot binary to the error message, so that the user has a better
hint about what is missing.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Message-Id: <1519725913-24852-1-git-send-email-thuth@redhat.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarFarhan Ali <alifm@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 83d2e94c

hw/s390x/ipl.c

+3 −2
Original line number Diff line number Diff line
@@ -380,7 +380,8 @@ static int load_netboot_image(Error **errp) 


    netboot_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, ipl->netboot_fw);

    if (netboot_filename == NULL) {

        error_setg(errp, "Could not find network bootloader");

        error_setg(errp, "Could not find network bootloader '%s'",

                   ipl->netboot_fw);

        goto unref_mr;

    }
@@ -489,7 +490,7 @@ void s390_ipl_prepare_cpu(S390CPU *cpu) 
    if (ipl->netboot) {

        if (load_netboot_image(&err) < 0) {

            error_report_err(err);

            vm_stop(RUN_STATE_INTERNAL_ERROR);

            exit(1);

        }

        ipl->qipl.netboot_start_addr = cpu_to_be64(ipl->start_addr);

    }