Commit c4dfc14b authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

ppc: abort if compat property contains an unknown value 



It is not possible to set the compat property to an unknown value with
powerpc_set_compat(). Something must have gone terribly wrong in QEMU,
if we detect an "Internal error" in powerpc_get_compat(). Let's abort then.

This patch also drops the "max_compat ? *max_compat : -1" construct. It is
useless since max_compat is dereferenced a few lines above.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 5cbc64de

target-ppc/translate_init.c

+2 −2
Original line number Diff line number Diff line
@@ -8446,8 +8446,8 @@ static void powerpc_get_compat(Object *obj, Visitor *v, const char *name, 
    case 0:

        break;

    default:

        error_setg(errp, "Internal error: compat is set to %x",

                   max_compat ? *max_compat : -1);

        error_report("Internal error: compat is set to %x", *max_compat);

        abort();

        break;

    }