Commit c326529b authored by Markus Armbruster's avatar Markus Armbruster Committed by Gerd Hoffmann
Browse files

usb/dev-storage: Avoid qerror_report_err() outside QMP handlers 



qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP.  It should not be used
elsewhere.

usb_msd_password_cb() is only called from within an HMP command
handler.  Replace by error_report_err().

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 7afcc1f9

hw/usb/dev-storage.c

+1 −2
Original line number Diff line number Diff line
@@ -559,8 +559,7 @@ static void usb_msd_password_cb(void *opaque, int err) 
    }



    if (local_err) {

        qerror_report_err(local_err);

        error_free(local_err);

        error_report_err(local_err);

        qdev_unplug(&s->dev.qdev, NULL);

    }

}