Commit c2924cea authored by John Snow's avatar John Snow Committed by Max Reitz
Browse files

block/mirror: don't install backing chain on abort 



In cases where we abort the block/mirror job, there's no point in
installing the new backing chain before we finish aborting.

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Message-id: 20180906130225.5118-6-jsnow@redhat.com
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 22dffcbe

block/mirror.c

+1 −1
Original line number Diff line number Diff line
@@ -642,7 +642,7 @@ static void mirror_exit(Job *job) 
     * required before it could become a backing file of target_bs. */

    bdrv_child_try_set_perm(mirror_top_bs->backing, 0, BLK_PERM_ALL,

                            &error_abort);

    if (s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {

    if (ret == 0 && s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {

        BlockDriverState *backing = s->is_none_mode ? src : s->base;

        if (backing_bs(target_bs) != backing) {

            bdrv_set_backing_hd(target_bs, backing, &local_err);