Commit c0e6ee9e authored by Andreas Färber's avatar Andreas Färber
Browse files

qom: Implement qom-set HMP command 



Re-implemented based on qmp_qom_set() to facilitate argument parsing.

Warn about ambiguous path arguments.

Reviewed-by: default avatarGonglei <arei.gonglei@huawei.com>
Tested-by: default avatarAlistair Francis <alistair.francis@xilinx.com>
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
parent 89d7fa9e

hmp-commands.hx

+13 −0
Original line number Diff line number Diff line
@@ -1684,6 +1684,19 @@ ETEXI 
STEXI

@item qom-list [@var{path}]

Print QOM properties of object at location @var{path}

ETEXI



    {

        .name       = "qom-set",

        .args_type  = "path:s,property:s,value:s",

        .params     = "path property value",

        .help       = "set QOM property",

        .mhandler.cmd  = hmp_qom_set,

    },



STEXI

@item qom-set @var{path} @var{property} @var{value}

Set QOM property @var{property} of object at location @var{path} to value @var{value}

ETEXI



    {

hmp.c

+21 −0
Original line number Diff line number Diff line
@@ -1892,3 +1892,24 @@ void hmp_qom_list(Monitor *mon, const QDict *qdict) 
    }

    hmp_handle_error(mon, &err);

}



void hmp_qom_set(Monitor *mon, const QDict *qdict)

{

    const char *path = qdict_get_str(qdict, "path");

    const char *property = qdict_get_str(qdict, "property");

    const char *value = qdict_get_str(qdict, "value");

    Error *err = NULL;

    bool ambiguous = false;

    Object *obj;



    obj = object_resolve_path(path, &ambiguous);

    if (obj == NULL) {

        error_set(&err, QERR_DEVICE_NOT_FOUND, path);

    } else {

        if (ambiguous) {

            monitor_printf(mon, "Warning: Path '%s' is ambiguous\n", path);

        }

        object_property_parse(obj, value, property, &err);

    }

    hmp_handle_error(mon, &err);

}

hmp.h

+1 −0
Original line number Diff line number Diff line
@@ -97,6 +97,7 @@ void hmp_object_del(Monitor *mon, const QDict *qdict); 
void hmp_info_memdev(Monitor *mon, const QDict *qdict);

void hmp_info_memory_devices(Monitor *mon, const QDict *qdict);

void hmp_qom_list(Monitor *mon, const QDict *qdict);

void hmp_qom_set(Monitor *mon, const QDict *qdict);

void object_add_completion(ReadLineState *rs, int nb_args, const char *str);

void object_del_completion(ReadLineState *rs, int nb_args, const char *str);

void device_add_completion(ReadLineState *rs, int nb_args, const char *str);