Commit c0aca935 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Michael Roth
Browse files

memory: Align MemoryRegionSections fields 



MemoryRegionSection includes an Int128 'size' field;
on some platforms the compiler causes an alignment of this to
a 128bit boundary, leaving 8 bytes of dead space.
This deadspace can be filled with junk.

Move the size field to the top avoiding unnecessary alignment.

Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190814175535.2023-2-dgilbert@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 44f85d32)
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 54c13049

include/exec/memory.h

+1 −1
Original line number Diff line number Diff line
@@ -487,10 +487,10 @@ static inline FlatView *address_space_to_flatview(AddressSpace *as) 
 * @nonvolatile: this section is non-volatile

 */

struct MemoryRegionSection {

    Int128 size;

    MemoryRegion *mr;

    FlatView *fv;

    hwaddr offset_within_region;

    Int128 size;

    hwaddr offset_within_address_space;

    bool readonly;

    bool nonvolatile;