Commit c025f689 authored by Stefan Weil's avatar Stefan Weil Committed by Peter Maydell
Browse files

wxx: Fix handling of files used for character devices 



On Windows, such files were not truncated like on all other hosts.
Now we also test whether truncation is needed when running on Windows.

The append case was also incorrect because it needs a different value
for the desired access mode.

Reported-by: default avatarBenjamin David Lunt <fys@fysnet.net>
Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-id: 1470114877-1466-1-git-send-email-sw@weilnetz.de
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent bd8eda53

qemu-char.c

+14 −2
Original line number Diff line number Diff line
@@ -4234,14 +4234,26 @@ static CharDriverState *qmp_chardev_open_file(const char *id, 
    ChardevFile *file = backend->u.file.data;

    ChardevCommon *common = qapi_ChardevFile_base(file);

    HANDLE out;

    DWORD accessmode;

    DWORD flags;



    if (file->has_in) {

        error_setg(errp, "input file not supported");

        return NULL;

    }



    out = CreateFile(file->out, GENERIC_WRITE, FILE_SHARE_READ, NULL,

                     OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);

    if (file->has_append && file->append) {

        /* Append to file if it already exists. */

        accessmode = FILE_GENERIC_WRITE & ~FILE_WRITE_DATA;

        flags = OPEN_ALWAYS;

    } else {

        /* Truncate file if it already exists. */

        accessmode = GENERIC_WRITE;

        flags = CREATE_ALWAYS;

    }



    out = CreateFile(file->out, accessmode, FILE_SHARE_READ, NULL, flags,

                     FILE_ATTRIBUTE_NORMAL, NULL);

    if (out == INVALID_HANDLE_VALUE) {

        error_setg(errp, "open %s failed", file->out);

        return NULL;