Commit bdfe5159 authored by Jan Beulich's avatar Jan Beulich Committed by Stefano Stabellini
Browse files

xen/MSI-X: really enforce alignment 



The way the generic infrastructure works the intention of not allowing
unaligned accesses can't be achieved by simply setting .unaligned to
false. The benefit is that we can now replace the conditionals in
{get,set}_entry_value() by assert()-s.

Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Signed-off-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
Reviewed-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
parent f0ada360

hw/xen/xen_pt_msi.c

+16 −6
Original line number Diff line number Diff line
@@ -421,17 +421,15 @@ int xen_pt_msix_update_remap(XenPCIPassthroughState *s, int bar_index) 


static uint32_t get_entry_value(XenPTMSIXEntry *e, int offset)

{

    return !(offset % sizeof(*e->latch))

           ? e->latch[offset / sizeof(*e->latch)] : 0;

    assert(!(offset % sizeof(*e->latch)));

    return e->latch[offset / sizeof(*e->latch)];

}



static void set_entry_value(XenPTMSIXEntry *e, int offset, uint32_t val)

{

    if (!(offset % sizeof(*e->latch)))

    {

    assert(!(offset % sizeof(*e->latch)));

    e->latch[offset / sizeof(*e->latch)] = val;

}

}



static void pci_msix_write(void *opaque, hwaddr addr,

                           uint64_t val, unsigned size)
@@ -494,6 +492,12 @@ static uint64_t pci_msix_read(void *opaque, hwaddr addr, 
    }

}



static bool pci_msix_accepts(void *opaque, hwaddr addr,

                             unsigned size, bool is_write)

{

    return !(addr & (size - 1));

}



static const MemoryRegionOps pci_msix_ops = {

    .read = pci_msix_read,

    .write = pci_msix_write,
@@ -502,7 +506,13 @@ static const MemoryRegionOps pci_msix_ops = { 
        .min_access_size = 4,

        .max_access_size = 4,

        .unaligned = false,

        .accepts = pci_msix_accepts

    },

    .impl = {

        .min_access_size = 4,

        .max_access_size = 4,

        .unaligned = false

    }

};



int xen_pt_msix_init(XenPCIPassthroughState *s, uint32_t base)