Commit bdd8e6b5 authored by Eric Blake's avatar Eric Blake Committed by Markus Armbruster
Browse files

qapi: Tighten qmp_input_end_list() 



The only way that qmp_input_pop() will set errp is if a dictionary
was the most recent thing pushed.  Since we don't have any
push(struct)/pop(list) or push(list)/pop(struct) mismatches (such
a mismatch is a programming bug), we therefore cannot set errp
inside qmp_input_end_list().  Make this obvious by
using &error_abort.  A later patch will then remove the errp
parameter of qmp_input_pop(), but that will first require the
larger task of splitting visit_end_struct().

Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-23-git-send-email-eblake@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 337283df

qapi/qmp-input-visitor.c

+1 −1
Original line number Diff line number Diff line
@@ -206,7 +206,7 @@ static void qmp_input_end_list(Visitor *v, Error **errp) 
{

    QmpInputVisitor *qiv = to_qiv(v);



    qmp_input_pop(qiv, errp);

    qmp_input_pop(qiv, &error_abort);

}



static void qmp_input_get_next_type(Visitor *v, const char *name, QType *type,