Commit bd88c780 authored by Alex Bennée's avatar Alex Bennée Committed by Paolo Bonzini
Browse files

qom/cpu: remove host_tid field 



This was only used by the gdbstub and even then was only being set for
subsequent threads. Rather the continue duplicating the number just
make the gdbstub get the information from TaskState structure.

Now the tid is correctly reported for all threads the bug I was seeing
with "vCont;C04:0;c" packets is fixed as the correct tid is reported
to gdb.

I moved cpu_gdb_index into the gdbstub to facilitate easy access to
the TaskState which is used elsewhere in gdbstub.

To prevent BSD failing to build I've included ts_tid into its
TaskStruct but not populated it - which was the same state as the old
cpu->host_tid. I'll leave it up to the BSD maintainers to actually
populate this properly if they want a working gdbstub with
user-threads.

Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarClaudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarLaurent Vivier <laurent@vivier.eu>

Message-Id: <20170712105216.747-4-alex.bennee@linaro.org>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent d2a6c857

bsd-user/qemu.h

+2 −0
Original line number Diff line number Diff line
@@ -85,6 +85,8 @@ struct emulated_sigtable { 
/* NOTE: we force a big alignment so that the stack stored after is

   aligned too */

typedef struct TaskState {

    pid_t ts_tid;     /* tid (or pid) of this task */



    struct TaskState *next;

    int used; /* non zero if used */

    struct image_info *info;

gdbstub.c

+2 −1
Original line number Diff line number Diff line
@@ -64,7 +64,8 @@ static inline int target_memory_rw_debug(CPUState *cpu, target_ulong addr, 
static inline int cpu_gdb_index(CPUState *cpu)

{

#if defined(CONFIG_USER_ONLY)

    return cpu->host_tid;

    TaskState *ts = (TaskState *) cpu->opaque;

    return ts->ts_tid;

#else

    return cpu->cpu_index + 1;

#endif

include/qom/cpu.h

+0 −2
Original line number Diff line number Diff line
@@ -265,7 +265,6 @@ struct qemu_work_item; 
 * @cpu_index: CPU index (informative).

 * @nr_cores: Number of cores within this CPU package.

 * @nr_threads: Number of threads within this CPU.

 * @host_tid: Host thread ID.

 * @running: #true if CPU is currently running (lockless).

 * @has_waiter: #true if a CPU is currently waiting for the cpu_exec_end;

 * valid under cpu_list_lock.
@@ -319,7 +318,6 @@ struct CPUState { 
    HANDLE hThread;

#endif

    int thread_id;

    uint32_t host_tid;

    bool running, has_waiter;

    struct QemuCond *halt_cond;

    bool thread_kicked;

linux-user/syscall.c

+0 −1
Original line number Diff line number Diff line
@@ -6219,7 +6219,6 @@ static void *clone_func(void *arg) 
    thread_cpu = cpu;

    ts = (TaskState *)cpu->opaque;

    info->tid = gettid();

    cpu->host_tid = info->tid;

    task_settid(ts);

    if (info->child_tidptr)

        put_user_u32(info->tid, info->child_tidptr);