Commit bd429a88 authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by John Snow
Browse files

block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint() 



The function is unused, drop it.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Message-id: 20190927122355.7344-6-vsementsov@virtuozzo.com
Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
parent f88676c1

block/qcow2-bitmap.c

+1 −14
Original line number Diff line number Diff line
@@ -1102,8 +1102,7 @@ Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs, 
    return list;

}



int qcow2_reopen_bitmaps_rw_hint(BlockDriverState *bs, bool *header_updated,

                                 Error **errp)

int qcow2_reopen_bitmaps_rw(BlockDriverState *bs, Error **errp)

{

    BDRVQcow2State *s = bs->opaque;

    Qcow2BitmapList *bm_list;
@@ -1111,10 +1110,6 @@ int qcow2_reopen_bitmaps_rw_hint(BlockDriverState *bs, bool *header_updated, 
    GSList *ro_dirty_bitmaps = NULL;

    int ret = 0;



    if (header_updated != NULL) {

        *header_updated = false;

    }



    if (s->nb_bitmaps == 0) {

        /* No bitmaps - nothing to do */

        return 0;
@@ -1156,9 +1151,6 @@ int qcow2_reopen_bitmaps_rw_hint(BlockDriverState *bs, bool *header_updated, 
            error_setg_errno(errp, -ret, "Can't update bitmap directory");

            goto out;

        }

        if (header_updated != NULL) {

            *header_updated = true;

        }

        g_slist_foreach(ro_dirty_bitmaps, set_readonly_helper, false);

    }
@@ -1169,11 +1161,6 @@ out: 
    return ret;

}



int qcow2_reopen_bitmaps_rw(BlockDriverState *bs, Error **errp)

{

    return qcow2_reopen_bitmaps_rw_hint(bs, NULL, errp);

}



/* Checks to see if it's safe to resize bitmaps */

int qcow2_truncate_bitmaps_check(BlockDriverState *bs, Error **errp)

{

block/qcow2.h

+0 −2
Original line number Diff line number Diff line
@@ -740,8 +740,6 @@ int qcow2_check_bitmaps_refcounts(BlockDriverState *bs, BdrvCheckResult *res, 
bool qcow2_load_dirty_bitmaps(BlockDriverState *bs, Error **errp);

Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs,

                                                Error **errp);

int qcow2_reopen_bitmaps_rw_hint(BlockDriverState *bs, bool *header_updated,

                                 Error **errp);

int qcow2_reopen_bitmaps_rw(BlockDriverState *bs, Error **errp);

int qcow2_truncate_bitmaps_check(BlockDriverState *bs, Error **errp);

void qcow2_store_persistent_dirty_bitmaps(BlockDriverState *bs, Error **errp);