Commit bbade206 authored by David Gibson's avatar David Gibson Committed by Alexander Graf
Browse files

pseries: Add more parameter validation in RTAS time of day functions 



Currently, the RTAS time of day functions only partially validate the
number of parameters they receive and return.  Because of how the
parameters are used, this is unlikely to lead to a crash, but it's messy.

This patch adds the missing checks.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent 12f42174

hw/ppc/spapr_rtc.c

+6 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ static void rtas_get_time_of_day(PowerPCCPU *cpu, sPAPREnvironment *spapr, 
{

    struct tm tm;



    if (nret != 8) {

    if ((nargs != 0) || (nret != 8)) {

        rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);

        return;

    }
@@ -60,6 +60,11 @@ static void rtas_set_time_of_day(PowerPCCPU *cpu, sPAPREnvironment *spapr, 
{

    struct tm tm;



    if ((nargs != 7) || (nret != 1)) {

        rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);

        return;

    }



    tm.tm_year = rtas_ld(args, 0) - 1900;

    tm.tm_mon = rtas_ld(args, 1) - 1;

    tm.tm_mday = rtas_ld(args, 2);