Commit bb6b6843 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Alexander Graf
Browse files

dump-guest-memory: Check for the correct return value 



We should check for error with s->note_size

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent d83af167

dump.c

+2 −2
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ typedef struct DumpState { 
    uint32_t sh_info;

    bool have_section;

    bool resume;

    size_t note_size;

    ssize_t note_size;

    hwaddr memory_offset;

    int fd;
@@ -765,7 +765,7 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter, 


    s->note_size = cpu_get_note_size(s->dump_info.d_class,

                                     s->dump_info.d_machine, nr_cpus);

    if (ret < 0) {

    if (s->note_size < 0) {

        error_set(errp, QERR_UNSUPPORTED);

        goto cleanup;

    }