Commit ba306c7a authored by Markus Armbruster's avatar Markus Armbruster Committed by Peter Maydell
Browse files

sd: Mark brittle abuse of blk_attach_dev() FIXME 



blk_attach_dev() fails here only when we're working for device
"sdhci-pci" (which already attached the backend), and then we don't
want to attach a second time.  If we ever create another failure mode,
we're setting up ourselves to using the same backend from multiple
frontends, which is likely to end in tears.  Can't clean this up this
close to the release, so mark it FIXME.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-id: 1449503710-3707-3-git-send-email-armbru@redhat.com
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 79f21707

hw/sd/sd.c

+1 −0
Original line number Diff line number Diff line
@@ -494,6 +494,7 @@ SDState *sd_init(BlockBackend *blk, bool is_spi) 
    if (sd->blk) {

        /* Attach dev if not already attached.  (This call ignores an

         * error return code if sd->blk is already attached.) */

        /* FIXME ignoring blk_attach_dev() failure is dangerously brittle */

        blk_attach_dev(sd->blk, sd);

        blk_set_dev_ops(sd->blk, &sd_block_ops, sd);

    }