Commit ba02ff90 authored by Igor Mammedov's avatar Igor Mammedov Committed by Michael S. Tsirkin
Browse files

tests: acpi: print error unable to dump ACPI table during rebuild 



Instead of just asserting print the error that lead to assert first.
While at it move assert into rebuild branch, which removes redundant
check done in case of !rebuild branch is taken (the later is taken
care of by g_assert_no_error).

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarWei Yang <richardw.yang@linux.intel.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1556808723-226478-16-git-send-email-imammedo@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent ae3c12a0

tests/bios-tables-test.c

+4 −1
Original line number Diff line number Diff line
@@ -195,11 +195,14 @@ static void dump_aml_files(test_data *data, bool rebuild) 
                                       sdt->aml, ext);

            fd = g_open(aml_file, O_WRONLY|O_TRUNC|O_CREAT,

                        S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);

            if (fd < 0) {

                perror(aml_file);

            }

            g_assert(fd >= 0);

        } else {

            fd = g_file_open_tmp("aml-XXXXXX", &sdt->aml_file, &error);

            g_assert_no_error(error);

        }

        g_assert(fd >= 0);



        ret = qemu_write_full(fd, sdt->aml, sdt->aml_len);

        g_assert(ret == sdt->aml_len);