Commit b90b9ecb authored Mar 26, 2020 by Nicholas Piggin Committed by David Gibson Apr 07, 2020

ppc/spapr: Add FWNMI machine check delivery warnings



Add some messages which explain problems and guest misbehaviour that
may be difficult to diagnose in rare cases of machine checks.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20200325142906.221248-4-npiggin@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

parent 6c3dd24c

hw/ppc/spapr_events.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -833,6 +833,8 @@ static void spapr_mce_dispatch_elog(PowerPCCPU *cpu, bool recovered)
		/* get rtas addr from fdt */
		rtas_addr = spapr_get_rtas_addr();
		if (!rtas_addr) {
		error_report(
		"FWNMI: Unable to deliver machine check to guest: rtas_addr not found.");
		qemu_system_guest_panicked(NULL);
		g_free(ext_elog);
		return;
		@@ -874,6 +876,8 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recovered)
		* that CPU called "ibm,nmi-interlock")
		*/
		if (spapr->fwnmi_machine_check_interlock == cpu->vcpu_id) {
		error_report(
		"FWNMI: Unable to deliver machine check to guest: nested machine check.");
		qemu_system_guest_panicked(NULL);
		return;
		}

hw/ppc/spapr_rtas.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -462,6 +462,9 @@ static void rtas_ibm_nmi_interlock(PowerPCCPU *cpu,
		}

		if (spapr->fwnmi_machine_check_addr == -1) {
		qemu_log_mask(LOG_GUEST_ERROR,
		"FWNMI: ibm,nmi-interlock RTAS called with FWNMI not registered.\n");

		/* NMI register not called */
		rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
		return;