Commit b8da57fa authored by Wei Jiangang's avatar Wei Jiangang Committed by Paolo Bonzini
Browse files

linux-user: complete omission of removing uses of strdup 



The 900cfbca just removed two unchecked uses of strdup
in fill_psinfo and missed the rest in core_dump_filename.
This patch fixes it.

Signed-off-by: default avatarWei Jiangang <weijg.fnst@cn.fujitsu.com>
Message-Id: <1459997185-15669-2-git-send-email-weijg.fnst@cn.fujitsu.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 7616f1c2

linux-user/elfload.c

+2 −5
Original line number Diff line number Diff line
@@ -2718,7 +2718,6 @@ static int core_dump_filename(const TaskState *ts, char *buf, 
                              size_t bufsize)

{

    char timestamp[64];

    char *filename = NULL;

    char *base_filename = NULL;

    struct timeval tv;

    struct tm tm;
@@ -2731,14 +2730,12 @@ static int core_dump_filename(const TaskState *ts, char *buf, 
        return (-1);

    }



    filename = strdup(ts->bprm->filename);

    base_filename = strdup(basename(filename));

    base_filename = g_path_get_basename(ts->bprm->filename);

    (void) strftime(timestamp, sizeof (timestamp), "%Y%m%d-%H%M%S",

                    localtime_r(&tv.tv_sec, &tm));

    (void) snprintf(buf, bufsize, "qemu_%s_%s_%d.core",

                    base_filename, timestamp, (int)getpid());

    free(base_filename);

    free(filename);

    g_free(base_filename);



    return (0);

}