Commit b7bca733 authored by Bharata B Rao's avatar Bharata B Rao Committed by Andreas Färber
Browse files

cpu: Convert cpu_index into a bitmap 

Currently CPUState::cpu_index is monotonically increasing and a newly
created CPU always gets the next higher index. The next available
index is calculated by counting the existing number of CPUs. This is
fine as long as we only add CPUs, but there are architectures which
are starting to support CPU removal, too. For an architecture like PowerPC
which derives its CPU identifier (device tree ID) from cpu_index, the
existing logic of generating cpu_index values causes problems.

With the currently proposed method of handling vCPU removal by parking
the vCPU fd in QEMU
(Ref: http://lists.gnu.org/archive/html/qemu-devel/2015-02/msg02604.html

),
generating cpu_index this way will not work for PowerPC.

This patch changes the way cpu_index is handed out by maintaining
a bit map of the CPUs that tracks both addition and removal of CPUs.

The CPU bitmap allocation logic is part of cpu_exec_init(), which is
called by instance_init routines of various CPU targets. Newly added
cpu_exec_exit() API handles the deallocation part and this routine is
called from generic CPU instance_finalize.

Note: This new CPU enumeration is for !CONFIG_USER_ONLY only.
CONFIG_USER_ONLY continues to have the old enumeration logic.

Signed-off-by: default avatarBharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarPeter Crosthwaite <peter.crosthwaite@xilinx.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarPeter Crosthwaite <crosthwaite.peter@gmail.com>
[AF: max_cpus -> MAX_CPUMASK_BITS]
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
parent 5a790cc4

exec.c

+53 −5
Original line number Diff line number Diff line
@@ -526,12 +526,57 @@ void tcg_cpu_address_space_init(CPUState *cpu, AddressSpace *as) 
}

#endif



#ifndef CONFIG_USER_ONLY

static DECLARE_BITMAP(cpu_index_map, MAX_CPUMASK_BITS);



static int cpu_get_free_index(Error **errp)

{

    int cpu = find_first_zero_bit(cpu_index_map, MAX_CPUMASK_BITS);



    if (cpu >= MAX_CPUMASK_BITS) {

        error_setg(errp, "Trying to use more CPUs than max of %d",

                   MAX_CPUMASK_BITS);

        return -1;

    }



    bitmap_set(cpu_index_map, cpu, 1);

    return cpu;

}



void cpu_exec_exit(CPUState *cpu)

{

    if (cpu->cpu_index == -1) {

        /* cpu_index was never allocated by this @cpu or was already freed. */

        return;

    }



    bitmap_clear(cpu_index_map, cpu->cpu_index, 1);

    cpu->cpu_index = -1;

}

#else



static int cpu_get_free_index(Error **errp)

{

    CPUState *some_cpu;

    int cpu_index = 0;



    CPU_FOREACH(some_cpu) {

        cpu_index++;

    }

    return cpu_index;

}



void cpu_exec_exit(CPUState *cpu)

{

}

#endif



void cpu_exec_init(CPUArchState *env, Error **errp)

{

    CPUState *cpu = ENV_GET_CPU(env);

    CPUClass *cc = CPU_GET_CLASS(cpu);

    CPUState *some_cpu;

    int cpu_index;

    Error *local_err = NULL;



#ifndef CONFIG_USER_ONLY

    cpu->as = &address_space_memory;
@@ -542,11 +587,14 @@ void cpu_exec_init(CPUArchState *env, Error **errp) 
#if defined(CONFIG_USER_ONLY)

    cpu_list_lock();

#endif

    cpu_index = 0;

    CPU_FOREACH(some_cpu) {

        cpu_index++;

    cpu_index = cpu->cpu_index = cpu_get_free_index(&local_err);

    if (local_err) {

        error_propagate(errp, local_err);

#if defined(CONFIG_USER_ONLY)

        cpu_list_unlock();

#endif

        return;

    }

    cpu->cpu_index = cpu_index;

    QTAILQ_INSERT_TAIL(&cpus, cpu, node);

#if defined(CONFIG_USER_ONLY)

    cpu_list_unlock();

include/qom/cpu.h

+1 −0
Original line number Diff line number Diff line
@@ -674,6 +674,7 @@ void cpu_watchpoint_remove_all(CPUState *cpu, int mask); 


void QEMU_NORETURN cpu_abort(CPUState *cpu, const char *fmt, ...)

    GCC_FMT_ATTR(2, 3);

void cpu_exec_exit(CPUState *cpu);



#ifdef CONFIG_SOFTMMU

extern const struct VMStateDescription vmstate_cpu_common;

qom/cpu.c

+7 −0
Original line number Diff line number Diff line
@@ -312,11 +312,17 @@ static void cpu_common_initfn(Object *obj) 
    CPUState *cpu = CPU(obj);

    CPUClass *cc = CPU_GET_CLASS(obj);



    cpu->cpu_index = -1;

    cpu->gdb_num_regs = cpu->gdb_num_g_regs = cc->gdb_num_core_regs;

    QTAILQ_INIT(&cpu->breakpoints);

    QTAILQ_INIT(&cpu->watchpoints);

}



static void cpu_common_finalize(Object *obj)

{

    cpu_exec_exit(CPU(obj));

}



static int64_t cpu_common_get_arch_id(CPUState *cpu)

{

    return cpu->cpu_index;
@@ -358,6 +364,7 @@ static const TypeInfo cpu_type_info = { 
    .parent = TYPE_DEVICE,

    .instance_size = sizeof(CPUState),

    .instance_init = cpu_common_initfn,

    .instance_finalize = cpu_common_finalize,

    .abstract = true,

    .class_size = sizeof(CPUClass),

    .class_init = cpu_class_init,