Commit b6f0474f authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Luiz Capitulino
Browse files

qapi: shortcut visits on errors 



We can exit very soon if we enter a visitor with a preexisting error.
This simplifies some cases because we will not have to deal with
obj being non-NULL while *obj is NULL.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent 8b714d37

scripts/qapi-visit.py

+9 −0
Original line number Diff line number Diff line
@@ -61,6 +61,9 @@ def generate_visit_struct(name, members): 


void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)

{

    if (error_is_set(errp)) {

        return;

    }

    visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), errp);

''',

                name=name)
@@ -81,6 +84,9 @@ void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, 
{

    GenericList *i, **head = (GenericList **)obj;



    if (error_is_set(errp)) {

        return;

    }

    visit_start_list(m, name, errp);



    for (*head = i = visit_next_list(m, head, errp); i; i = visit_next_list(m, &i, errp)) {
@@ -112,6 +118,9 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error ** 
{

    Error *err = NULL;



    if (error_is_set(errp)) {

        return;

    }

    visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err);

    visit_type_%(name)sKind(m, &(*obj)->kind, "type", &err);

    if (err) {