Commit b690d679 authored by Peter Lieven's avatar Peter Lieven Committed by Luiz Capitulino
Browse files

Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()" 



This reverts commit 25a70175.

Turns out the argument *can* be null: QEMU now segfaults if it
receives an invalid parameter via a qmp command instead of throwing an
error.

For example:
{ "execute": "blockdev-add",
     "arguments": { "options" : { "driver": "invalid-driver" } } }

CC: qemu-stable@nongnu.org
Signed-off-by: default avatarPeter Lieven <pl@kamp.de>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent cc162655

qapi/qapi-dealloc-visitor.c

+3 −1
Original line number Diff line number Diff line
@@ -131,8 +131,10 @@ static void qapi_dealloc_end_list(Visitor *v, Error **errp) 
static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name,

                                  Error **errp)

{

    if (obj) {

        g_free(*obj);

    }

}



static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name,

                                  Error **errp)