Commit b56d417b authored Jul 15, 2016 by Paolo Bonzini Committed by David Gibson Jul 18, 2016

target-ppc: fix left shift overflow in hpte_page_shift



ps->pte_enc is a 32-bit value, which is shifted left and then compared
to a 64-bit value.  It needs a cast before the shift.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

parent 28f33318

target-ppc/mmu-hash64.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -478,7 +478,7 @@ static unsigned hpte_page_shift(const struct ppc_one_seg_page_size *sps,

		mask = ((1ULL << ps->page_shift) - 1) & HPTE64_R_RPN;

		if ((pte1 & mask) == (ps->pte_enc << HPTE64_R_RPN_SHIFT)) {
		if ((pte1 & mask) == ((uint64_t)ps->pte_enc << HPTE64_R_RPN_SHIFT)) {
		return ps->page_shift;
		}
		}