Commit b27a6b8b authored by John Snow's avatar John Snow
Browse files

block/backup: prohibit backup from using in use bitmaps 



If the bitmap is frozen, we shouldn't touch it.

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20181002230218.13949-6-jsnow@redhat.com
Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
parent b053bb55

blockdev.c

+6 −6
Original line number Diff line number Diff line
@@ -3513,10 +3513,10 @@ static BlockJob *do_drive_backup(DriveBackup *backup, JobTxn *txn, 
            bdrv_unref(target_bs);

            goto out;

        }

        if (bdrv_dirty_bitmap_qmp_locked(bmap)) {

        if (bdrv_dirty_bitmap_user_locked(bmap)) {

            error_setg(errp,

                       "Bitmap '%s' is currently locked and cannot be used for "

                       "backup", backup->bitmap);

                       "Bitmap '%s' is currently in use by another operation"

                       " and cannot be used for backup", backup->bitmap);

            goto out;

        }

    }
@@ -3621,10 +3621,10 @@ BlockJob *do_blockdev_backup(BlockdevBackup *backup, JobTxn *txn, 
            error_setg(errp, "Bitmap '%s' could not be found", backup->bitmap);

            goto out;

        }

        if (bdrv_dirty_bitmap_qmp_locked(bmap)) {

        if (bdrv_dirty_bitmap_user_locked(bmap)) {

            error_setg(errp,

                       "Bitmap '%s' is currently locked and cannot be used for "

                       "backup", backup->bitmap);

                       "Bitmap '%s' is currently in use by another operation"

                       " and cannot be used for backup", backup->bitmap);

            goto out;

        }

    }