Commit b24b9d94 authored by Igor Mammedov's avatar Igor Mammedov Committed by Michael S. Tsirkin
Browse files

tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table() 



at best it's confusing that array for list of tables to be tested
against reference tables is allocated within test_acpi_dsdt_table()
and at worst it would just overwrite list of tables if they were
added before test_acpi_dsdt_table().
Move array initialization to test_acpi_one() before we start
processing tables.

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent a0c167a1

tests/bios-tables-test.c

+2 −2
Original line number Diff line number Diff line
@@ -234,12 +234,11 @@ static void test_acpi_dsdt_table(test_data *data) 
    uint32_t addr = le32_to_cpu(data->fadt_table.dsdt);



    memset(&dsdt_table, 0, sizeof(dsdt_table));

    data->tables = g_array_new(false, true, sizeof(AcpiSdtTable));



    test_dst_table(&dsdt_table, addr);

    ACPI_ASSERT_CMP(dsdt_table.header.signature, "DSDT");



    /* Place DSDT first */

    /* Since DSDT isn't in RSDT, add DSDT to ASL test tables list manually */

    g_array_append_val(data->tables, dsdt_table);

}
@@ -636,6 +635,7 @@ static void test_acpi_one(const char *params, test_data *data) 


    boot_sector_test();



    data->tables = g_array_new(false, true, sizeof(AcpiSdtTable));

    test_acpi_rsdp_address(data);

    test_acpi_rsdp_table(data);

    test_acpi_rsdt_table(data);