Commit b247767a authored by Kevin Wolf's avatar Kevin Wolf
Browse files

commit: Fix error handling 



Apparently some kind of mismerge happened in commit 8dfba279, which
broke the error handling without any real reason by removing the
assignment of the return value to ret in a blk_insert_bs() call.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
parent ff79d5e9

block/commit.c

+1 −1
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ void commit_start(const char *job_id, BlockDriverState *bs, 


    /* Required permissions are already taken with block_job_add_bdrv() */

    s->top = blk_new(0, BLK_PERM_ALL);

    blk_insert_bs(s->top, top, errp);

    ret = blk_insert_bs(s->top, top, errp);

    if (ret < 0) {

        goto fail;

    }