Commit b21da4e5 authored by Hans de Goede's avatar Hans de Goede Committed by Gerd Hoffmann
Browse files

xhci: Fix memory leak on xhci_disable_ep 



The USBPacket-s in the transfers need to be cleaned up so that the memory
allocated by the iovec in there gets freed.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 518ad5f2

hw/usb/hcd-xhci.c

+5 −0
Original line number Diff line number Diff line
@@ -1380,6 +1380,7 @@ static TRBCCode xhci_disable_ep(XHCIState *xhci, unsigned int slotid, 
{

    XHCISlot *slot;

    XHCIEPContext *epctx;

    int i;



    trace_usb_xhci_ep_disable(slotid, epid);

    assert(slotid >= 1 && slotid <= xhci->numslots);
@@ -1400,6 +1401,10 @@ static TRBCCode xhci_disable_ep(XHCIState *xhci, unsigned int slotid, 
        xhci_free_streams(epctx);

    }



    for (i = 0; i < ARRAY_SIZE(epctx->transfers); i++) {

        usb_packet_cleanup(&epctx->transfers[i].packet);

    }



    xhci_set_ep_state(xhci, epctx, NULL, EP_DISABLED);



    timer_free(epctx->kick_timer);