Commit b1fde1ef authored by Laurent Vivier's avatar Laurent Vivier Committed by Dr. David Alan Gilbert
Browse files

hmp: fix "dump-quest-memory" segfault (ppc) 



Running QEMU with
    qemu-system-ppc64 -M none -nographic -m 256
and executing
    dump-guest-memory /dev/null 0 8192
results in segfault

Fix by checking if we have CPU, and exit with
error if there is no CPU:

    (qemu) dump-guest-memory /dev/null
    this feature or command is not currently supported

Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Message-Id: <20170913142036.2469-2-lvivier@redhat.com>
Acked-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent 9d81b2d2

target/ppc/arch_dump.c

+9 −2
Original line number Diff line number Diff line
@@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc; 
int cpu_get_dump_info(ArchDumpInfo *info,

                      const struct GuestPhysBlockList *guest_phys_blocks)

{

    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);

    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);

    PowerPCCPU *cpu;

    PowerPCCPUClass *pcc;



    if (first_cpu == NULL) {

        return -1;

    }



    cpu = POWERPC_CPU(first_cpu);

    pcc = POWERPC_CPU_GET_CLASS(cpu);



    info->d_machine = PPC_ELF_MACHINE;

    info->d_class = ELFCLASS;