Commit b162b49a authored by Hani Benhabiles's avatar Hani Benhabiles Committed by Luiz Capitulino
Browse files

monitor: Add netdev_add type argument completion. 



Also update the command's documentation.

Signed-off-by: default avatarHani Benhabiles <hani@linux.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent 40d19394

hmp-commands.hx

+2 −1
Original line number Diff line number Diff line
@@ -1234,9 +1234,10 @@ ETEXI 
    {

        .name       = "netdev_add",

        .args_type  = "netdev:O",

        .params     = "[user|tap|socket|hubport|netmap],id=str[,prop=value][,...]",

        .params     = "[user|tap|socket|vde|bridge|hubport|netmap],id=str[,prop=value][,...]",

        .help       = "add host network device",

        .mhandler.cmd = hmp_netdev_add,

        .command_completion = netdev_add_completion,

    },



STEXI

hmp.h

+1 −0
Original line number Diff line number Diff line
@@ -101,5 +101,6 @@ void sendkey_completion(ReadLineState *rs, int nb_args, const char *str); 
void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);

void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);

void set_link_completion(ReadLineState *rs, int nb_args, const char *str);

void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str);



#endif

monitor.c

+15 −0
Original line number Diff line number Diff line
@@ -4303,6 +4303,21 @@ void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str) 
    qapi_free_ChardevBackendInfoList(start);

}



void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str)

{

    size_t len;

    int i;



    if (nb_args != 2) {

        return;

    }

    len = strlen(str);

    readline_set_completion_index(rs, len);

    for (i = 0; NetClientOptionsKind_lookup[i]; i++) {

        add_completion_option(rs, str, NetClientOptionsKind_lookup[i]);

    }

}



void device_add_completion(ReadLineState *rs, int nb_args, const char *str)

{

    GSList *list, *elt;