Commit b0588cb5 authored by BALATON Zoltan's avatar BALATON Zoltan Committed by Gerd Hoffmann
Browse files

ati-vga: Do not allow unaligned access via index register 

According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so
unaligned access via this register should not be possible.
This also fixes problems reported in bug #1878134.

Buglink: https://bugs.launchpad.net/qemu/+bug/1878134


Signed-off-by: default avatarBALATON Zoltan <balaton@eik.bme.hu>
Tested-by: default avatarAlexander Bulekov <alxndr@bu.edu>
Acked-by: default avatarAlexander Bulekov <alxndr@bu.edu>
Message-id: 20200516132352.39E9374594E@zero.eik.bme.hu
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent debe78ce

hw/display/ati.c

+1 −1
Original line number Diff line number Diff line
@@ -511,7 +511,7 @@ static void ati_mm_write(void *opaque, hwaddr addr, 
    }

    switch (addr) {

    case MM_INDEX:

        s->regs.mm_index = data;

        s->regs.mm_index = data & ~3;

        break;

    case MM_DATA ... MM_DATA + 3:

        /* indexed access to regs or memory */