Commit b021d1c0 authored by Maxime Coquelin's avatar Maxime Coquelin Committed by Paolo Bonzini
Browse files

memory: fix off-by-one error in memory_region_notify_one() 



This patch fixes an off-by-one error that could lead to the
notifyee to receive notifications for ranges it is not
registered to.

The bug has been spotted by code review.

Fixes: bd2bfa4c ("memory: introduce memory_region_notify_one()")
Cc: qemu-stable@nongnu.org
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: default avatarMaxime Coquelin <maxime.coquelin@redhat.com>
Message-Id: <20171010094247.10173-4-maxime.coquelin@redhat.com>
Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 076a93d7

memory.c

+1 −1
Original line number Diff line number Diff line
@@ -1892,7 +1892,7 @@ void memory_region_notify_one(IOMMUNotifier *notifier, 
     * Skip the notification if the notification does not overlap

     * with registered range.

     */

    if (notifier->start > entry->iova + entry->addr_mask + 1 ||

    if (notifier->start > entry->iova + entry->addr_mask ||

        notifier->end < entry->iova) {

        return;

    }