Commit afd32160 authored by Stefan Weil's avatar Stefan Weil Committed by Anthony Liguori
Browse files

VNC: Fix memory allocation (wrong structure size). 



Pointer vs addresses a VncDisplay structure,
so it is sufficient to allocate sizeof(VncDisplay)
or sizeof(*vs) bytes instead of the much larger
sizeof(VncState).

Maybe the misleading name should be fixed, too:
the code contains many places where vs is used,
sometimes it is a VncState *, sometimes it is a
VncDisplay *. vd would be a better name.

Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 91a073a9

vnc.c

+1 −2
Original line number Diff line number Diff line
@@ -2033,9 +2033,8 @@ static void vnc_listen_read(void *opaque) 


void vnc_display_init(DisplayState *ds)

{

    VncDisplay *vs;

    VncDisplay *vs = qemu_mallocz(sizeof(*vs));



    vs = qemu_mallocz(sizeof(VncState));

    dcl = qemu_mallocz(sizeof(DisplayChangeListener));



    ds->opaque = vs;